Fix outputFields logic conflicted between aggr & dynamic schema #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sre-ci-robot
added
approved
Codecov Report
@@ Coverage Diff @@
## master #585 +/- ##
=======================================
Coverage 82.89% 82.89%
=======================================
Files 40 40
Lines 3647 3647
=======================================
Hits 3023 3023
- Misses 511 512 +1
+ Partials 113 112 -1
|
congqixia
force-pushed
the
fix_aggr_conflict_dynamic_schema
branch
2 times, most recently
from
0102b30 to
0e617e2
Compare
This PR let output result set only check extra fields If Milvus server returns more column than output fields specified, just return them Signed-off-by: Congqi Xia <[email protected]>
congqixia
force-pushed
the
fix_aggr_conflict_dynamic_schema
branch
from
0e617e2 to
da40f54
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia, jiaoew1991 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #584
/kind bug
This PR let output result set only check extra fields
If Milvus server returns more column than output fields specified, just return them